When purchasing spices buy small quantities and write the date purchased on the container. I would replace them after a year or two at most. Many spices will lose their potency and will have a mild scent compared to when they were new. If this is the case replace sooner than later. Penzeys is a good source for spices and herbs as well as cocoa and chocolate.